[Mjpeg-users] [patch] [media] zoran: remove duplicate ZR050_MO_COMP define

[Dan Carpenter]

The ZR050_MO_COMP define is cut and pasted twice so we can delete the
second instance.

Signed-off-by: Dan Carpenter <***@oracle.com>

diff --git a/drivers/media/pci/zoran/zr36050.h b/drivers/media/pci/zoran/zr36050.h
index 9f52f0c..ea083ad 100644
--- a/drivers/media/pci/zoran/zr36050.h
+++ b/drivers/media/pci/zoran/zr36050.h
@@ -126,7 +126,6 @@ struct zr36050 {
/* zr36050 mode register bits */

#define ZR050_MO_COMP 0x80
-#define ZR050_MO_COMP 0x80
#define ZR050_MO_ATP 0x40
#define ZR050_MO_PASS2 0x20
#define ZR050_MO_TLM 0x10

[Bernhard Praschinger]

Hallo

More than 15 years have passed since the first working module for a
zoran chipset based PCI card existed. Well not included into the Linux
kernel at that time.
According to my experience, the driver started to make problems when 64
Bit and more than 2GB Ram became popular. In May 2011 there was a patch
available that made the cards working in machines with more than 2GB
Ram, and AMD&Intel x64 architectures. According to my information that
patch did not make it into the linux kernel (the Patch was for the Linux
2.6.38 Kernel)

So people spend time looking at code that does not work (well it
compiles and does not cause troubles), and send patches the world will
never honor.

I haven't had a question related to a zoran based card's in years. So
I'm quite sure there are not much users out there that use a zoran based
video cards in a up to date environment.

Because of that I would really suggest that somebody removes the whole
zoran driver from the linux kernel.

Post by Dan Carpenter
The ZR050_MO_COMP define is cut and pasted twice so we can delete the
second instance.
diff --git a/drivers/media/pci/zoran/zr36050.h b/drivers/media/pci/zoran/zr36050.h
index 9f52f0c..ea083ad 100644
--- a/drivers/media/pci/zoran/zr36050.h
+++ b/drivers/media/pci/zoran/zr36050.h
@@ -126,7 +126,6 @@ struct zr36050 {
/* zr36050 mode register bits */
#define ZR050_MO_COMP 0x80
-#define ZR050_MO_COMP 0x80
#define ZR050_MO_ATP 0x40
#define ZR050_MO_PASS2 0x20
#define ZR050_MO_TLM 0x10
------------------------------------------------------------------------------
HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions
Find What Matters Most in Your Big Data with HPCC Systems
Open Source. Fast. Scalable. Simple. Ideal for Dirty Data.
Leverages Graph Analysis for Fast Processing & Easy Data Exploration
http://p.sf.net/sfu/hpccsystems
_______________________________________________
Mjpeg-users mailing list
https://lists.sourceforge.net/lists/listinfo/mjpeg-users

Kind Regards
Bernhard Praschinger
Docwriter, probably the last mjpegtools maintainer

[Markus Künne]

Post by Bernhard Praschinger
I haven't had a question related to a zoran based card's in years. So
I'm quite sure there are not much users out there that use a zoran based
video cards in a up to date environment.
Because of that I would really suggest that somebody removes the whole
zoran driver from the linux kernel.

Just my twocent..

I have such a card but when I tried to use it last time for a recording,
I've had to jump through quite a few loops:

I needed an older kernel as video4linux v1 rotated out of support a few
years ago.
After installing an older kernel, I found out that dependance on OSS is
hardcoded into the tools. Neither Alsa-OSS nor Pulse-OSS worked.

It seems like the code is not really maintained any more. Personally, I
try to move to a USB-grabber solution (not sure if well supported in
linux). Hardware En-/De-coder support seems to have lost any importance
as modern CPUs are fast enough to support better and more versatile
codecs; Playback via Zoran cards seems unneccessary as graphic cards
feature better outputs (S-Video seems really deprecated when compared to
the HDMI output even cheap cards have nowadays).
I can't think of a good usecase for those cards in an up-to-date
environment.

I used to hope that Linux will always support "old" hardware but maybe
it's time to move on.

tl;dr: I support the request for removal.

Regards,

Markus

[Bernhard Praschinger]

Hallo

Post by Markus Künne

Post by Bernhard Praschinger
I haven't had a question related to a zoran based card's in years. So
I'm quite sure there are not much users out there that use a zoran based
video cards in a up to date environment.
Because of that I would really suggest that somebody removes the whole
zoran driver from the linux kernel.

Just my twocent..
I have such a card but when I tried to use it last time for a recording,
I needed an older kernel as video4linux v1 rotated out of support a few
years ago.
After installing an older kernel, I found out that dependance on OSS is
hardcoded into the tools. Neither Alsa-OSS nor Pulse-OSS worked.

Well I would say it the other way there was no developer that made the
mjpegtools support for ALSA, and the OSS emulation worked not well. v4l2
should have worked I think just for video recording with the patch.

The problem was than that the card did support v4l2, as far as I
remember but you needed mplayer to get a picture on the screen (xawtv
and other TV Apps didn't work). But with that the recording didn't work.

I stopped using the mjpegtools based cards (Iomega BUZ, Pinnacle DC30)
about the time the 2.6.3x Kernel came around. Not sure which kernel it was.

Currently lavplay is not working with the OSS emulation to play back a
video and sound. playing back without sound still work.

Post by Markus Künne
It seems like the code is not really maintained any more. Personally, I
try to move to a USB-grabber solution (not sure if well supported in
linux). Hardware En-/De-coder support seems to have lost any importance
as modern CPUs are fast enough to support better and more versatile
codecs; Playback via Zoran cards seems unneccessary as graphic cards
feature better outputs (S-Video seems really deprecated when compared to
the HDMI output even cheap cards have nowadays).
I can't think of a good usecase for those cards in an up-to-date
environment.

All the analog stuff is fading away. You are right, hardware compression
is not a problem any more, there are fast CPU and GPU available, and a
modern harddisk is even able to write the raw data (~100MB/s), that was
not able on normal consumer hardware when the Zoran chipset was developed.

The Hardware I currently use is a Canopus ADVC-100, a firewire based
external box which works well. (a current product seems to be a Grass
Valley ADVC110)

Post by Markus Künne
I used to hope that Linux will always support "old" hardware but maybe
it's time to move on.

New computers often don't even have the old PCI Slots any more.

Post by Markus Künne
tl;dr: I support the request for removal.

We will see what happens, I didn't get any word from the kernel developers.

auf hoffentlich bald,

Berni the Chaos of Woodquarter

Email: ***@utanet.at
www: http://www.lysator.liu.se/~gz/bernhard

[Trent Piepho]

On Mon, Jun 23, 2014 at 10:40 AM, Bernhard Praschinger

Post by Bernhard Praschinger
The problem was than that the card did support v4l2, as far as I
remember but you needed mplayer to get a picture on the screen (xawtv
and other TV Apps didn't work). But with that the recording didn't work.

I seem to recall that I fixed the zoran kernel driver to work with tv
apps like mplayer, xawtv, and tvtime. It's not v4l1 only. The
compressed capture OTOH, I don't think was every updated to work with
V4L2 compressed capture spec. Probably because lavtools also wasn't
updated to use V4L2 compressed capture.

This driver does serve as a nice reference for any complex video
hardware, since it does uncompressed capture, video overlay, and
compressed capture. I'm not aware of any other driver than can do all
three.

As these are PCI cards, they can't really be used in newer computers anyway.

[Hans Verkuil]

Hi Bernhard,

Post by Bernhard Praschinger
Hallo
More than 15 years have passed since the first working module for a
zoran chipset based PCI card existed. Well not included into the
Linux kernel at that time. According to my experience, the driver
started to make problems when 64 Bit and more than 2GB Ram became
popular. In May 2011 there was a patch available that made the cards
working in machines with more than 2GB Ram, and AMD&Intel x64
architectures. According to my information that patch did not make it
into the linux kernel (the Patch was for the Linux 2.6.38 Kernel)

As far as I know it works fine on machines with a lot of memory, at
least the last time I tested it it was OK (with a 3.<something> kernel).

Post by Bernhard Praschinger
So people spend time looking at code that does not work (well it
compiles and does not cause troubles), and send patches the world
will never honor.

I'll honor them. I still have zoran hardware and it is on my todo list
of drivers to update to the latest frameworks.

Post by Bernhard Praschinger
I haven't had a question related to a zoran based card's in years. So
I'm quite sure there are not much users out there that use a zoran
based video cards in a up to date environment.
Because of that I would really suggest that somebody removes the whole zoran driver from the linux kernel.

It's not blocking new development, so there is no need to remove it.
Besides, I have zoran hardware, so even if it is blocking new developments
I should be able to fix it.

Regards,

Hans

Post by Bernhard Praschinger

Post by Dan Carpenter
The ZR050_MO_COMP define is cut and pasted twice so we can delete the
second instance.
diff --git a/drivers/media/pci/zoran/zr36050.h b/drivers/media/pci/zoran/zr36050.h
index 9f52f0c..ea083ad 100644
--- a/drivers/media/pci/zoran/zr36050.h
+++ b/drivers/media/pci/zoran/zr36050.h
@@ -126,7 +126,6 @@ struct zr36050 {
/* zr36050 mode register bits */
#define ZR050_MO_COMP 0x80
-#define ZR050_MO_COMP 0x80
#define ZR050_MO_ATP 0x40
#define ZR050_MO_PASS2 0x20
#define ZR050_MO_TLM 0x10
------------------------------------------------------------------------------
HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions
Find What Matters Most in Your Big Data with HPCC Systems
Open Source. Fast. Scalable. Simple. Ideal for Dirty Data.
Leverages Graph Analysis for Fast Processing & Easy Data Exploration
http://p.sf.net/sfu/hpccsystems
_______________________________________________
Mjpeg-users mailing list
https://lists.sourceforge.net/lists/listinfo/mjpeg-users

Kind Regards
Bernhard Praschinger
Docwriter, probably the last mjpegtools maintainer
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
More majordomo info at http://vger.kernel.org/majordomo-info.html

[Bernhard Praschinger]

Hallo

I did remove some mailinglists because I think that it is not important
for them.

Anyway I'm surprised that someone still seems to has such a card built
into the computer.

Post by Hans Verkuil

Post by Bernhard Praschinger
More than 15 years have passed since the first working module for a
zoran chipset based PCI card existed. Well not included into the
Linux kernel at that time. According to my experience, the driver
started to make problems when 64 Bit and more than 2GB Ram became
popular. In May 2011 there was a patch available that made the cards
working in machines with more than 2GB Ram, and AMD&Intel x64
architectures. According to my information that patch did not make it
into the linux kernel (the Patch was for the Linux 2.6.38 Kernel)

As far as I know it works fine on machines with a lot of memory, at
least the last time I tested it it was OK (with a 3.<something> kernel).

For me the card makes just sense to use if you can at least view the
video. If recording does not work that would be a big disadvantage. If
playback of videos does not work that would be no big deal for me.

I'm quite sure that recording video with sound does not work. Because of
the Alsa OSS emulation. That is no fault of the kernel team. Nobody did
spend time to convert the recording from OSS to Alsa.

Post by Hans Verkuil

Post by Bernhard Praschinger
So people spend time looking at code that does not work (well it
compiles and does not cause troubles), and send patches the world
will never honor.

I'll honor them. I still have zoran hardware and it is on my todo list
of drivers to update to the latest frameworks.

Sounds like a challenge :)

I still have a computer with one PCI slot and 16GB Ram. That means that
I will spend some time adding again the Buz and DC30 into my computer
and testing what current works (on my Opensuse 13.1 3.11.10-17-desktop
#1 SMP PREEMPT ... x86_64 GNU/Linux)

And you help me when I encounter kernel related problems ? I hope you
accept.

BTW: It will take about 3 weeks till I find time to set up for the test.
So there is time to consider.

Post by Hans Verkuil

Post by Bernhard Praschinger
I haven't had a question related to a zoran based card's in years. So
I'm quite sure there are not much users out there that use a zoran
based video cards in a up to date environment.
Because of that I would really suggest that somebody removes the whole zoran driver from the linux kernel.

It's not blocking new development, so there is no need to remove it.
Besides, I have zoran hardware, so even if it is blocking new developments
I should be able to fix it.

The "problem" I have with the current situation that I don't know how
many people still use the zoran based card's on a regular base. To know
if You and all the other people spend the time for something that is
active used. Or you are just taking care of a empty shell.

auf hoffentlich bald,

Berni the Chaos of Woodquarter

Email: ***@utanet.at
www: http://www.lysator.liu.se/~gz/bernhard

[Hans Verkuil]

Post by Bernhard Praschinger
Hallo
I did remove some mailinglists because I think that it is not important
for them.
Anyway I'm surprised that someone still seems to has such a card built
into the computer.

Post by Hans Verkuil

Post by Bernhard Praschinger
More than 15 years have passed since the first working module for a
zoran chipset based PCI card existed. Well not included into the
Linux kernel at that time. According to my experience, the driver
started to make problems when 64 Bit and more than 2GB Ram became
popular. In May 2011 there was a patch available that made the cards
working in machines with more than 2GB Ram, and AMD&Intel x64
architectures. According to my information that patch did not make it
into the linux kernel (the Patch was for the Linux 2.6.38 Kernel)

As far as I know it works fine on machines with a lot of memory, at
least the last time I tested it it was OK (with a 3.<something> kernel).

For me the card makes just sense to use if you can at least view the
video. If recording does not work that would be a big disadvantage. If
playback of videos does not work that would be no big deal for me.
I'm quite sure that recording video with sound does not work. Because of
the Alsa OSS emulation. That is no fault of the kernel team. Nobody did
spend time to convert the recording from OSS to Alsa.

Post by Hans Verkuil

Post by Bernhard Praschinger
So people spend time looking at code that does not work (well it
compiles and does not cause troubles), and send patches the world
will never honor.

I'll honor them. I still have zoran hardware and it is on my todo list
of drivers to update to the latest frameworks.

Sounds like a challenge :)
I still have a computer with one PCI slot and 16GB Ram. That means that
I will spend some time adding again the Buz and DC30 into my computer
and testing what current works (on my Opensuse 13.1 3.11.10-17-desktop
#1 SMP PREEMPT ... x86_64 GNU/Linux)
And you help me when I encounter kernel related problems ? I hope you
accept.

Uh, within limits :-)

I just tried my DC10 and it works a little bit. Meaning that I did manage
to capture, but that the V4L2 implementation is so bad that I basically
was unable to use the qv4l2 capture utility.

A lot of the problems usually disappear if the driver is converted to use
the videobuf2 framework.

Post by Bernhard Praschinger
BTW: It will take about 3 weeks till I find time to set up for the test.
So there is time to consider.

Is there a reason why you want to work on this? Otherwise I would just
leave it and eventually I will rework the zoran driver. When that will
happen is something I don't know.

Post by Bernhard Praschinger

Post by Hans Verkuil

Post by Bernhard Praschinger
I haven't had a question related to a zoran based card's in years. So
I'm quite sure there are not much users out there that use a zoran
based video cards in a up to date environment.
Because of that I would really suggest that somebody removes the whole zoran driver from the linux kernel.

It's not blocking new development, so there is no need to remove it.
Besides, I have zoran hardware, so even if it is blocking new developments
I should be able to fix it.

The "problem" I have with the current situation that I don't know how
many people still use the zoran based card's on a regular base. To know
if You and all the other people spend the time for something that is
active used. Or you are just taking care of a empty shell.

I haven't seen any requests for help in a very long time, so I suspect very
few people, if any, still use it. I'm crazy enough that I like cleaning up
old driver code and getting it to work again, but that's just me :-)

Regards,

Hans

Post by Bernhard Praschinger
auf hoffentlich bald,
Berni the Chaos of Woodquarter
www: http://www.lysator.liu.se/~gz/bernhard

[Emmanuel Fusté]

Hello Hans,

Le 05/07/2014 18:13, Hans Verkuil a écrit :
.....

Post by Hans Verkuil
I'm crazy enough that I like cleaning up
old driver code and getting it to work again, but that's just me :-)

Just for this, you're my hero !!

Regards,
Emmanuel.

PS: I expect to resume work on Marvel/Rainbow Runner Zoran based matrox
boards one day, but not in a near future and I did not know by which
side I will tackle the beast ..... but this is another story.

Post by Hans Verkuil
Regards,
Hans

Post by Bernhard Praschinger
auf hoffentlich bald,
Berni the Chaos of Woodquarter
www: http://www.lysator.liu.se/~gz/bernhard

------------------------------------------------------------------------------
Open source business process management suite built on Java and Eclipse
Turn processes into business applications with Bonita BPM Community Edition
Quickly connect people, data, and systems into organized workflows
Winner of BOSSIE, CODIE, OW2 and Gartner awards
http://p.sf.net/sfu/Bonitasoft
_______________________________________________
Mjpeg-users mailing list
https://lists.sourceforge.net/lists/listinfo/mjpeg-users